Hey Tuf, if you're looking for the easiest option, compatible IDE drives from the list is the way to go. I think the largest you'll find will be 500GB and I don't think they're manufactured anymore, so ebay / used will be your best bet.
Otherwise, I've had great results with (and yet to have any compatibility issue) with
SATA Drives ... Both spinning and Solid states using a SATA to IDE Adapter.
Fact :Storage-wise for the xbox we're limited to 2TB.
For Spinning SATA Drives, Brandwise I'd say stick with Western Digital & Seagate as they are mostly compatible and able to be locked (some not all).
For SATA Solid states, I've successfully used Samsung 2.5 and Kingston 2.5 drives 120GB & 256GB.
I also recommend and this is optional, getting a Long 18 inch +.. (long as possible because you're going to have to twist it in to fit) 40 pin 80wire IDE cable.... this will be an upgrade from the Xbox's Stock 40 wire 40pin cable... many users have reported better performance. (see link below)https://www.amazon.com/Ultra-Cable-Devi ... le+80+wire
This IDE to SATA adapter worked for me and was pretty cheap (someone may chime in with a better option):https://www.amazon.com/gp/product/B002Y ... UTF8&psc=1
Now depending on your Modding Method ( I prefer Tsop because YOU DON'T have to lock the drive and this increases your available drive options) but since you mentioned it here.. I think you want the locking option and are softmodding.
For Soft modding / swap and lock method, you can use the included Jumper pin on the SATA to IDE adapter board, to switch the drive from slave to master to get chimp to lock it.
I have softmodded and locked in a while as I tsop mod, so I'm not sure / can't recall if the drive locking capability is actually made possible by / or impacted by the IDE / SATA adapter. Some how I recall being able to lock a solid state drive... but I could be recalling wrong.